Commit 8c3e05c8 authored by Andi Kleen's avatar Andi Kleen Committed by Arnaldo Carvalho de Melo
Browse files

perf script: Don't force less for non tty output with --xed 



--xed currently forces less. When piping the output to other scripts
this can waste a lot of CPU time because less is rather slow.
I've seen it using up a full core on its own in a pipeline.
Only force less when the output is actually a terminal.

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lore.kernel.org/lkml/20200522020914.527564-1-andi@firstfloor.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent e2ce1059

tools/perf/builtin-script.c

+4 −1
Original line number Diff line number Diff line
@@ -3301,7 +3301,10 @@ static int parse_xed(const struct option *opt __maybe_unused, 
		     const char *str __maybe_unused,

		     int unset __maybe_unused)

{

	if (isatty(1))

		force_pager("xed -F insn: -A -64 | less");

	else

		force_pager("xed -F insn: -A -64");

	return 0;

}