Commit 8c384bfa authored by Thomas Graf's avatar Thomas Graf Committed by David S. Miller
Browse files

[IPv6] prefix: Convert prefix notifications to use rtnl_notify() 



Fixes a wrong use of current->pid as netlink pid.

Signed-off-by: default avatarThomas Graf <tgraf@suug.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8d7a76c9

net/ipv6/addrconf.c

+14 −11
Original line number Diff line number Diff line
@@ -3506,20 +3506,23 @@ static void inet6_prefix_notify(int event, struct inet6_dev *idev, 
			 struct prefix_info *pinfo)

{

	struct sk_buff *skb;

	int size = NLMSG_SPACE(sizeof(struct prefixmsg) + INET6_PREFIX_RTA_SPACE);

	int payload = sizeof(struct prefixmsg) + INET6_PREFIX_RTA_SPACE;

	int err = -ENOBUFS;



	skb = alloc_skb(size, GFP_ATOMIC);

	if (!skb) {

		netlink_set_err(rtnl, 0, RTNLGRP_IPV6_PREFIX, ENOBUFS);

		return;

	}

	if (inet6_fill_prefix(skb, idev, pinfo, current->pid, 0, event, 0) < 0) {

	skb = nlmsg_new(nlmsg_total_size(payload), GFP_ATOMIC);

	if (skb == NULL)

		goto errout;



	err = inet6_fill_prefix(skb, idev, pinfo, 0, 0, event, 0);

	if (err < 0) {

		kfree_skb(skb);

		netlink_set_err(rtnl, 0, RTNLGRP_IPV6_PREFIX, EINVAL);

		return;

		goto errout;

	}

	NETLINK_CB(skb).dst_group = RTNLGRP_IPV6_PREFIX;

	netlink_broadcast(rtnl, skb, 0, RTNLGRP_IPV6_PREFIX, GFP_ATOMIC);



	err = rtnl_notify(skb, 0, RTNLGRP_IPV6_PREFIX, NULL, GFP_ATOMIC);

errout:

	if (err < 0)

		rtnl_set_sk_err(RTNLGRP_IPV6_PREFIX, err);

}



static struct rtnetlink_link inet6_rtnetlink_table[RTM_NR_MSGTYPES] = {