Commit 8c33915d authored Nov 28, 2021 by Hans de Goede

platform/x86: wmi: Add no_notify_data flag to struct wmi_driver



Some WMI implementations do notifies on WMI objects without a _WED method
allow WMI drivers to indicate that _WED should not be called for notifies
on the WMI objects the driver is bound to.

Instead the driver's notify callback will simply be called with a NULL
data argument.

Reported-by: Yauhen Kharuzhy <jekhor@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211128190031.405620-3-hdegoede@redhat.com

parent 99188786

drivers/platform/x86/wmi.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -1331,11 +1331,13 @@ static void acpi_wmi_notify_handler(acpi_handle handle, u32 event,
		struct acpi_buffer evdata = { ACPI_ALLOCATE_BUFFER, NULL };
		acpi_status status;

		if (!driver->no_notify_data) {
		status = get_event_data(wblock, &evdata);
		if (ACPI_FAILURE(status)) {
		dev_warn(&wblock->dev.dev, "failed to get event data\n");
		return;
		}
		}

		if (driver->notify)
		driver->notify(&wblock->dev, evdata.pointer);

include/linux/wmi.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -35,6 +35,7 @@ extern int set_required_buffer_size(struct wmi_device *wdev, u64 length);
		struct wmi_driver {
		struct device_driver driver;
		const struct wmi_device_id *id_table;
		bool no_notify_data;

		int (probe)(struct wmi_device wdev, const void *context);
		void (remove)(struct wmi_device wdev);