Unverified Commit 8c2d9bf5 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/omap: plane: Remove redundant color encoding and range initialisation



The omap KMS driver will call drm_plane_create_color_properties() with
a default encoding and range values of BT601 and Full Range,
respectively.

Since the initial value wasn't carried over in the state, the driver had
to set it again in omap_plane_reset(). However, the helpers have been
adjusted to set it properly at reset, so this is not needed anymore.

Reviewed-by: default avatarTomi Valkeinen <tomba@kernel.org>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220221095918.18763-23-maxime@cerno.tech
parent 9a48ab11
Loading
Loading
Loading
Loading
+0 −3
Original line number Diff line number Diff line
@@ -403,7 +403,6 @@ void omap_plane_install_properties(struct drm_plane *plane,

static void omap_plane_reset(struct drm_plane *plane)
{
	struct omap_plane *omap_plane = to_omap_plane(plane);
	struct omap_plane_state *omap_state;

	if (plane->state)
@@ -414,8 +413,6 @@ static void omap_plane_reset(struct drm_plane *plane)
		return;

	__drm_atomic_helper_plane_reset(plane, &omap_state->base);
	plane->state->color_encoding = DRM_COLOR_YCBCR_BT601;
	plane->state->color_range = DRM_COLOR_YCBCR_FULL_RANGE;
}

static struct drm_plane_state *