Commit 8c252d3b authored by Kieran Bingham's avatar Kieran Bingham Committed by Laurent Pinchart
Browse files

drm: rcar-du: Fix DIDSR field name 



The DIDSR fields named LDCS were incorrectly defined as LCDS.
Both the Gen2 and Gen3 documentation refer to the fields as the "LVDS
Dot Clock Select".

Correct the definitions.

Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarKieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
parent ce35299e

drivers/gpu/drm/rcar-du/rcar_du_group.c

+2 −2
Original line number Diff line number Diff line
@@ -122,10 +122,10 @@ static void rcar_du_group_setup_didsr(struct rcar_du_group *rgrp) 
	didsr = DIDSR_CODE;

	for (i = 0; i < num_crtcs; ++i, ++rcrtc) {

		if (rcdu->info->lvds_clk_mask & BIT(rcrtc->index))

			didsr |= DIDSR_LCDS_LVDS0(i)

			didsr |= DIDSR_LDCS_LVDS0(i)

			      |  DIDSR_PDCS_CLK(i, 0);

		else

			didsr |= DIDSR_LCDS_DCLKIN(i)

			didsr |= DIDSR_LDCS_DCLKIN(i)

			      |  DIDSR_PDCS_CLK(i, 0);

	}

drivers/gpu/drm/rcar-du/rcar_du_regs.h

+4 −4
Original line number Diff line number Diff line
@@ -257,10 +257,10 @@ 


#define DIDSR			0x20028

#define DIDSR_CODE		(0x7790 << 16)

#define DIDSR_LCDS_DCLKIN(n)	(0 << (8 + (n) * 2))

#define DIDSR_LCDS_LVDS0(n)	(2 << (8 + (n) * 2))

#define DIDSR_LCDS_LVDS1(n)	(3 << (8 + (n) * 2))

#define DIDSR_LCDS_MASK(n)	(3 << (8 + (n) * 2))

#define DIDSR_LDCS_DCLKIN(n)	(0 << (8 + (n) * 2))

#define DIDSR_LDCS_LVDS0(n)	(2 << (8 + (n) * 2))

#define DIDSR_LDCS_LVDS1(n)	(3 << (8 + (n) * 2))

#define DIDSR_LDCS_MASK(n)	(3 << (8 + (n) * 2))

#define DIDSR_PDCS_CLK(n, clk)	(clk << ((n) * 2))

#define DIDSR_PDCS_MASK(n)	(3 << ((n) * 2))