Commit 8c1f2081 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Kalle Valo
Browse files

ath10k: remove unnecessary code 



The array fields in struct wmi_start_scan_arg that are checked here are
fixed size arrays so they can never be NULL.

Addresses-Coverity-ID: 1260031
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent fb53905c

drivers/net/wireless/ath/ath10k/wmi.c

+0 −9
Original line number Diff line number Diff line
@@ -5948,15 +5948,6 @@ static struct sk_buff *ath10k_wmi_10_4_op_gen_init(struct ath10k *ar) 


int ath10k_wmi_start_scan_verify(const struct wmi_start_scan_arg *arg)

{

	if (arg->ie_len && !arg->ie)

		return -EINVAL;

	if (arg->n_channels && !arg->channels)

		return -EINVAL;

	if (arg->n_ssids && !arg->ssids)

		return -EINVAL;

	if (arg->n_bssids && !arg->bssids)

		return -EINVAL;



	if (arg->ie_len > WLAN_SCAN_PARAMS_MAX_IE_LEN)

		return -EINVAL;

	if (arg->n_channels > ARRAY_SIZE(arg->channels))