Commit 8c1ee346 authored by Kalesh AP's avatar Kalesh AP Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Remove unnecessary checks 

The NULL check inside bnxt_qplib_del_sgid() and bnxt_qplib_add_sgid()
always return false as the "sgid_tbl" inside "rdev->qplib_res" is a static
memory.

Fixes: 1ac5a404 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Link: https://lore.kernel.org/r/1684478897-12247-8-git-send-email-selvin.xavier@broadcom.com


Signed-off-by: default avatarKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: default avatarSelvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 07d5ce14

drivers/infiniband/hw/bnxt_re/qplib_sp.c

+0 −8
Original line number Diff line number Diff line
@@ -233,10 +233,6 @@ int bnxt_qplib_del_sgid(struct bnxt_qplib_sgid_tbl *sgid_tbl, 
	struct bnxt_qplib_rcfw *rcfw = res->rcfw;

	int index;



	if (!sgid_tbl) {

		dev_err(&res->pdev->dev, "SGID table not allocated\n");

		return -EINVAL;

	}

	/* Do we need a sgid_lock here? */

	if (!sgid_tbl->active) {

		dev_err(&res->pdev->dev, "SGID table has no active entries\n");
@@ -297,10 +293,6 @@ int bnxt_qplib_add_sgid(struct bnxt_qplib_sgid_tbl *sgid_tbl, 
	struct bnxt_qplib_rcfw *rcfw = res->rcfw;

	int i, free_idx;



	if (!sgid_tbl) {

		dev_err(&res->pdev->dev, "SGID table not allocated\n");

		return -EINVAL;

	}

	/* Do we need a sgid_lock here? */

	if (sgid_tbl->active == sgid_tbl->max) {

		dev_err(&res->pdev->dev, "SGID table is full\n");