Commit 8c1beb98 authored by Steve French's avatar Steve French
Browse files

cifs: minor clarification in comments 



Clarify meaning (in comments) meaning of various
options for debug messages in cifs.ko. Also fixed
trivial formatting/style issue with previous patch.

Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent f80eaedd

fs/cifs/cifs_debug.h

+12 −0
Original line number Original line Diff line number Diff line
@@ -47,6 +47,18 @@ extern int cifsFYI; 
 */

 */

#ifdef CONFIG_CIFS_DEBUG

#ifdef CONFIG_CIFS_DEBUG







/*

 * When adding tracepoints and debug messages we have various choices.

 * Some considerations:

 *

 * Use cifs_dbg(VFS, ...) for things we always want logged, and the user to see

 *     cifs_info(...) slightly less important, admin can filter via loglevel > 6

 *     cifs_dbg(FYI, ...) minor debugging messages, off by default

 *     trace_smb3_*  ftrace functions are preferred for complex debug messages

 *                 intended for developers or experienced admins, off by default

 */



/* Information level messages, minor events */

/* Information level messages, minor events */

#define cifs_info_func(ratefunc, fmt, ...)			\

#define cifs_info_func(ratefunc, fmt, ...)			\

do {								\

do {								\

fs/cifs/cifsfs.c

+4 −2
Original line number Original line Diff line number Diff line
@@ -717,8 +717,10 @@ cifs_smb3_do_mount(struct file_system_type *fs_type, 
	struct cifs_mnt_data mnt_data;

	struct cifs_mnt_data mnt_data;

	struct dentry *root;

	struct dentry *root;





	/* Prints in Kernel / CIFS log the attempted mount operation *

	/*

	 *	IF CIFS_DEBUG && cifs_FYI */

	 * Prints in Kernel / CIFS log the attempted mount operation

	 *	If CIFS_DEBUG && cifs_FYI

	 */

	if (cifsFYI)

	if (cifsFYI)

		cifs_dbg(FYI, "Devname: %s flags: %d\n", dev_name, flags);

		cifs_dbg(FYI, "Devname: %s flags: %d\n", dev_name, flags);

	else

	else