Commit 8c030d78 authored Nov 15, 2020 by Gal Pressman Committed by Jason Gunthorpe Nov 16, 2020

RDMA/efa: Remove .create_ah callback assignment

Drivers now expose two callbacks for address handle creation, one for
uverbs and one for kverbs. EFA only supports uverbs so the .create_ah
assignment can be removed. Fix the core code caller to check the proper
function pointer.

Link: https://lore.kernel.org/r/20201115103404.48829-3-galpress@amazon.com


Signed-off-by: Gal Pressman <galpress@amazon.com>
Acked-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent 31e2daa1

drivers/infiniband/core/verbs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -516,7 +516,7 @@ static struct ib_ah _rdma_create_ah(struct ib_pd pd,

		might_sleep_if(flags & RDMA_CREATE_AH_SLEEPABLE);

		if (!device->ops.create_ah)
		if (!udata && !device->ops.create_ah)
		return ERR_PTR(-EOPNOTSUPP);

		ah = rdma_zalloc_drv_obj_gfp(

drivers/infiniband/hw/efa/efa_main.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -245,7 +245,6 @@ static const struct ib_device_ops efa_dev_ops = {
		.alloc_hw_stats = efa_alloc_hw_stats,
		.alloc_pd = efa_alloc_pd,
		.alloc_ucontext = efa_alloc_ucontext,
		.create_ah = efa_create_ah,
		.create_cq = efa_create_cq,
		.create_qp = efa_create_qp,
		.create_user_ah = efa_create_ah,