Commit 8bfd4e02 authored by Konrad Rzeszutek Wilk's avatar Konrad Rzeszutek Wilk
Browse files

xen/pciback: Cleanup the driver based on checkpatch warnings and errors. 



Checkpatch found some extra warnings and errors. This mega
patch fixes them all in one big swoop. We also spruce
up the pcistub_ids to use DEFINE_PCI_DEVICE_TABLE macro
(suggested by Jan Beulich).

Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 30edc14b

drivers/xen/xen-pciback/pci_stub.c

+3 −3
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ 
#include <linux/pci.h>

#include <linux/wait.h>

#include <linux/sched.h>

#include <asm/atomic.h>

#include <linux/atomic.h>

#include <xen/events.h>

#include <asm/xen/pci.h>

#include <asm/xen/hypervisor.h>
@@ -486,7 +486,7 @@ static void pcistub_remove(struct pci_dev *dev) 
	}

}



static const struct pci_device_id pcistub_ids[] = {

static DEFINE_PCI_DEVICE_TABLE(pcistub_ids) = {

	{

	 .vendor = PCI_ANY_ID,

	 .device = PCI_ANY_ID,

drivers/xen/xen-pciback/pciback.h

+3 −3
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
#include <linux/list.h>

#include <linux/spinlock.h>

#include <linux/workqueue.h>

#include <asm/atomic.h>

#include <linux/atomic.h>

#include <xen/interface/io/pciif.h>



struct pci_dev_entry {

drivers/xen/xen-pciback/xenbus.c

+8 −8
Original line number Diff line number Diff line
@@ -695,8 +695,8 @@ int __init pciback_xenbus_register(void) 
{

	pciback_wq = create_workqueue("pciback_workqueue");

	if (!pciback_wq) {

		printk(KERN_ERR "pciback_xenbus_register: create"

			"pciback_workqueue failed\n");

		printk(KERN_ERR "%s: create"

			"pciback_workqueue failed\n", __func__);

		return -EFAULT;

	}

	return xenbus_register_backend(&xenbus_pciback_driver);

drivers/xen/xen-pciback/conf_space.c

+2 −2

File changed.

Contains only whitespace changes.

drivers/xen/xen-pciback/conf_space_header.c

+21 −21

File changed.

Contains only whitespace changes.