Commit 8bf94e64 authored by Feras Daoud's avatar Feras Daoud Committed by Saeed Mahameed
Browse files

net/mlx5: Rearm the FW tracer after each tracer event 



The current design does not arm the tracer if traces are available before
the tracer string database is fully loaded, leading to an unfunctional tracer.
This fix will rearm the tracer every time the FW triggers tracer event
regardless of the tracer strings database status.

Fixes: c71ad41c ("net/mlx5: FW tracer, events handling")
Signed-off-by: default avatarFeras Daoud <ferasda@nvidia.com>
Signed-off-by: default avatarRoy Novich <royno@nvidia.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 3008e6a0

drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c

+5 −2
Original line number Diff line number Diff line
@@ -675,6 +675,9 @@ static void mlx5_fw_tracer_handle_traces(struct work_struct *work) 
	if (!tracer->owner)

		return;



	if (unlikely(!tracer->str_db.loaded))

		goto arm;



	block_count = tracer->buff.size / TRACER_BLOCK_SIZE_BYTE;

	start_offset = tracer->buff.consumer_index * TRACER_BLOCK_SIZE_BYTE;
@@ -732,6 +735,7 @@ static void mlx5_fw_tracer_handle_traces(struct work_struct *work) 
						      &tmp_trace_block[TRACES_PER_BLOCK - 1]);

	}



arm:

	mlx5_fw_tracer_arm(dev);

}
@@ -1136,7 +1140,6 @@ static int fw_tracer_event(struct notifier_block *nb, unsigned long action, void 
		queue_work(tracer->work_queue, &tracer->ownership_change_work);

		break;

	case MLX5_TRACER_SUBTYPE_TRACES_AVAILABLE:

		if (likely(tracer->str_db.loaded))

		queue_work(tracer->work_queue, &tracer->handle_traces_work);

		break;

	default: