Commit 8bf48897 authored by Oded Gabbay's avatar Oded Gabbay
Browse files

drivers/accel: define kconfig and register a new major 



Add a new Kconfig for the accel subsystem. The Kconfig currently
contains only the basic CONFIG_DRM_ACCEL option that will be used to
decide whether to compile the accel registration code. Therefore, the
kconfig option is defined as bool.

The accel code will be compiled as part of drm.ko and will be called
directly from the DRM core code. The reason we compile it as part of
drm.ko and not as a separate module is because of cyclic dependency
between drm.ko and the separate module (if it would have existed).
This is due to the fact that DRM core code calls accel functions and
vice-versa.

The accelerator devices will be exposed to the user space with a new,
dedicated major number - 261.

The accel init function registers the new major number as a char device
and create corresponding sysfs and debugfs root entries, similar to
what is done in DRM init function.

I added a new header called drm_accel.h to include/drm/, that will hold
the prototypes of the drm_accel.c functions. In case CONFIG_DRM_ACCEL
is set to 'N', that header will contain empty inline implementations of
those functions, to allow DRM core code to compile successfully
without dependency on CONFIG_DRM_ACCEL.

I Updated the MAINTAINERS file accordingly with the newly added folder
and I have taken the liberty to appropriate the dri-devel mailing list
and the dri-devel IRC channel for the accel subsystem.

Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: default avatarDave Airlie <airlied@redhat.com>
Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Tested-by: default avatarJacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: default avatarMelissa Wen <mwen@igalia.com>
parent fc58764b

Documentation/admin-guide/devices.txt

+5 −0
Original line number Diff line number Diff line
@@ -3080,6 +3080,11 @@ 
		  ...

		  255 = /dev/osd255	256th OSD Device



 261 char	Compute Acceleration Devices

		  0 = /dev/accel/accel0	First acceleration device

		  1 = /dev/accel/accel1	Second acceleration device

		    ...



 384-511 char	RESERVED FOR DYNAMIC ASSIGNMENT

		Character devices that request a dynamic allocation of major

		number will take numbers starting from 511 and downward,

MAINTAINERS

+8 −0
Original line number Diff line number Diff line
@@ -6833,6 +6833,14 @@ F: include/drm/drm* 
F:	include/linux/vga*

F:	include/uapi/drm/drm*









DRM COMPUTE ACCELERATORS DRIVERS AND FRAMEWORK









M:	Oded Gabbay <ogabbay@kernel.org>









L:	dri-devel@lists.freedesktop.org









S:	Maintained









C:	irc://irc.oftc.net/dri-devel









T:	git https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/accel.git









F:	drivers/accel/

















DRM DRIVERS FOR ALLWINNER A10









M:	Maxime Ripard <mripard@kernel.org>









M:	Chen-Yu Tsai <wens@csie.org>
































drivers/Kconfig



+2
−0






























Original line number
Diff line number
Diff line







@@ -99,6 +99,8 @@ source "drivers/media/Kconfig"

















source "drivers/video/Kconfig"



















source "drivers/accel/Kconfig"



















source "sound/Kconfig"



















source "drivers/hid/Kconfig"
































drivers/accel/Kconfig
0 → 100644



+24
−0






























Original line number
Diff line number
Diff line









# SPDX-License-Identifier: GPL-2.0-only









#









# Compute Acceleration device configuration









#









# This framework provides support for compute acceleration devices, such









# as, but not limited to, Machine-Learning and Deep-Learning acceleration









# devices









#









menuconfig DRM_ACCEL









	bool "Compute Acceleration Framework"









	depends on DRM









	help









	  Framework for device drivers of compute acceleration devices, such









	  as, but not limited to, Machine-Learning and Deep-Learning









	  acceleration devices.









	  If you say Y here, you need to select the module that's right for









	  your acceleration device from the list below.









	  This framework is integrated with the DRM subsystem as compute









	  accelerators and GPUs share a lot in common and can use almost the









	  same infrastructure code.









	  Having said that, acceleration devices will have a different









	  major number than GPUs, and will be exposed to user-space using









	  different device files, called accel/accel* (in /dev, sysfs









	  and debugfs).
























drivers/accel/drm_accel.c
0 → 100644



+83
−0






























Original line number
Diff line number
Diff line









// SPDX-License-Identifier: GPL-2.0



















/*









 * Copyright 2022 HabanaLabs, Ltd.









 * All Rights Reserved.









 *









 */



















#include <linux/debugfs.h>









#include <linux/device.h>



















#include <drm/drm_accel.h>









#include <drm/drm_ioctl.h>









#include <drm/drm_print.h>



















static struct dentry *accel_debugfs_root;









static struct class *accel_class;



















static char *accel_devnode(struct device *dev, umode_t *mode)









{









	return kasprintf(GFP_KERNEL, "accel/%s", dev_name(dev));









}



















static int accel_sysfs_init(void)









{









	accel_class = class_create(THIS_MODULE, "accel");









	if (IS_ERR(accel_class))









		return PTR_ERR(accel_class);



















	accel_class->devnode = accel_devnode;



















	return 0;









}



















static void accel_sysfs_destroy(void)









{









	if (IS_ERR_OR_NULL(accel_class))









		return;









	class_destroy(accel_class);









	accel_class = NULL;









}



















static int accel_stub_open(struct inode *inode, struct file *filp)









{









	return -EOPNOTSUPP;









}



















static const struct file_operations accel_stub_fops = {









	.owner = THIS_MODULE,









	.open = accel_stub_open,









	.llseek = noop_llseek,









};



















void accel_core_exit(void)









{









	unregister_chrdev(ACCEL_MAJOR, "accel");









	debugfs_remove(accel_debugfs_root);









	accel_sysfs_destroy();









}



















int __init accel_core_init(void)









{









	int ret;



















	ret = accel_sysfs_init();









	if (ret < 0) {









		DRM_ERROR("Cannot create ACCEL class: %d\n", ret);









		goto error;









	}



















	accel_debugfs_root = debugfs_create_dir("accel", NULL);



















	ret = register_chrdev(ACCEL_MAJOR, "accel", &accel_stub_fops);









	if (ret < 0)









		DRM_ERROR("Cannot register ACCEL major: %d\n", ret);



















error:









	/*









	 * Any cleanup due to errors will be done in drm_core_exit() that









	 * will call accel_core_exit()









	 */









	return ret;









}