Commit 8b73b45d authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Christoph Hellwig
Browse files

nvme-tcp: block BH in sk state_change sk callback 



The TCP stack can run from process context for a long time
so we should disable BH here.

Fixes: 3f2304f8 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 79695dcd

drivers/nvme/host/tcp.c

+2 −2
Original line number Diff line number Diff line
@@ -870,7 +870,7 @@ static void nvme_tcp_state_change(struct sock *sk) 
{

	struct nvme_tcp_queue *queue;



	read_lock(&sk->sk_callback_lock);

	read_lock_bh(&sk->sk_callback_lock);

	queue = sk->sk_user_data;

	if (!queue)

		goto done;
@@ -891,7 +891,7 @@ static void nvme_tcp_state_change(struct sock *sk) 


	queue->state_change(sk);

done:

	read_unlock(&sk->sk_callback_lock);

	read_unlock_bh(&sk->sk_callback_lock);

}



static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)