Commit 8b3bdd99 authored by Steffen Maier's avatar Steffen Maier Committed by Martin K. Petersen
Browse files

scsi: zfcp: Report port fc_security as unknown early during remote cable pull 

On remote cable pull, a zfcp_port keeps its status and only gets
ZFCP_STATUS_PORT_LINK_TEST added. Only after an ADISC timeout, we would
actually start port recovery and remove ZFCP_STATUS_COMMON_UNBLOCKED which
zfcp_sysfs_port_fc_security_show() detected and reported as "unknown"
instead of the old and possibly stale zfcp_port->connection_info.

Add check for ZFCP_STATUS_PORT_LINK_TEST for timely "unknown" report.

Link: https://lore.kernel.org/r/20210702160922.2667874-1-maier@linux.ibm.com


Fixes: a17c7846 ("scsi: zfcp: report FC Endpoint Security in sysfs")
Cc: <stable@vger.kernel.org> #5.7+
Reviewed-by: default avatarBenjamin Block <bblock@linux.ibm.com>
Signed-off-by: default avatarSteffen Maier <maier@linux.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 93aa71ad

drivers/s390/scsi/zfcp_sysfs.c

+1 −0
Original line number Diff line number Diff line
@@ -487,6 +487,7 @@ static ssize_t zfcp_sysfs_port_fc_security_show(struct device *dev, 
	if (0 == (status & ZFCP_STATUS_COMMON_OPEN) ||

	    0 == (status & ZFCP_STATUS_COMMON_UNBLOCKED) ||

	    0 == (status & ZFCP_STATUS_PORT_PHYS_OPEN) ||

	    0 != (status & ZFCP_STATUS_PORT_LINK_TEST) ||

	    0 != (status & ZFCP_STATUS_COMMON_ERP_FAILED) ||

	    0 != (status & ZFCP_STATUS_COMMON_ACCESS_BOXED))

		i = sprintf(buf, "unknown\n");