Commit 8b32bf5e authored by NeilBrown's avatar NeilBrown
Browse files

md: md_clear_badblocks should return an error code on failure. 



Julia Lawall and coccinelle report that md_clear_badblocks always
returns 0, despite appearing to have an error path.
The error path really should return an error code.  ENOSPC is
reasonably appropriate.

Reported-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 67f45548

drivers/md/md.c

+1 −1
Original line number Diff line number Diff line
@@ -8343,7 +8343,7 @@ static int md_clear_badblocks(struct badblocks *bb, sector_t s, int sectors) 
			if (a < s) {

				/* we need to split this range */

				if (bb->count >= MD_MAX_BADBLOCKS) {

					rv = 0;

					rv = -ENOSPC;

					goto out;

				}

				memmove(p+lo+1, p+lo, (bb->count - lo) * 8);