Commit 8b30fb40 authored by Icenowy Zheng's avatar Icenowy Zheng Committed by Benjamin Tissoires
Browse files

HID: nintendo: deregister home LED when it fails 



Some Pro Controller compatible controllers do not support home LED, and
will fail when setting it. Currently this leads to probe failure.

Change the code that fails probing to deregistering home LED.

Signed-off-by: default avatarIcenowy Zheng <icenowy@aosc.io>
Reviewed-by: default avatarDaniel J. Ogorchock <djogorchock@gmail.com>
Reviewed-by: default avatarSilvan Jegen <s.jegen@gmail.com>
[bentiss: changed "dflt" to "default"]
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20220415100432.23453-1-icenowy@aosc.io
parent a1f76426

drivers/hid/hid-nintendo.c

+2 −3
Original line number Diff line number Diff line
@@ -1904,9 +1904,8 @@ static int joycon_leds_create(struct joycon_ctlr *ctlr) 
		/* Set the home LED to 0 as default state */

		ret = joycon_home_led_brightness_set(led, 0);

		if (ret) {

			hid_err(hdev, "Failed to set home LED dflt; ret=%d\n",

									ret);

			return ret;

			hid_warn(hdev, "Failed to set home LED default, unregistering home LED");

			devm_led_classdev_unregister(&hdev->dev, led);

		}

	}