Commit 8b226173 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

media: imx: imx7-media-csi: Don't set PIXEL_BIT in CSICR1 



The PIXEL_BIT field of the CSICR1 register is documented as setting the
Bayer data width to 10 bits, and is set by the driver for all non-YUV
pixel formats. Test code from NXP showed that the bit shouldn't be set
for Bayer formats, and this was confirmed by experimentation with RAW8
capture (which doesn't work when setting the field) and RAW10 capture
(for which setting the field doesn't seem to make a difference) on
i.MX8MM with an OV5640 sensor connected over CSI-2. Don't set it.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Tested-by: default avatarMartin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent a581c87c

drivers/staging/media/imx/imx7-media-csi.c

+0 −15
Original line number Diff line number Diff line
@@ -495,21 +495,6 @@ static void imx7_csi_configure(struct imx7_csi *csi) 
			cr18 |= BIT_MIPI_DATA_FORMAT_YUV422_8B;

			break;

		}



		switch (out_pix->pixelformat) {

		case V4L2_PIX_FMT_Y10:

		case V4L2_PIX_FMT_Y12:

		case V4L2_PIX_FMT_SBGGR8:

		case V4L2_PIX_FMT_SGBRG8:

		case V4L2_PIX_FMT_SGRBG8:

		case V4L2_PIX_FMT_SRGGB8:

		case V4L2_PIX_FMT_SBGGR16:

		case V4L2_PIX_FMT_SGBRG16:

		case V4L2_PIX_FMT_SGRBG16:

		case V4L2_PIX_FMT_SRGGB16:

			cr1 |= BIT_PIXEL_BIT;

			break;

		}

	}



	imx7_csi_reg_write(csi, cr1, CSI_CSICR1);