Commit 8af85f71 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: compress: remove unneed check condition 



In only call path of __cluster_may_compress(), __f2fs_write_data_pages()
has checked SBI_POR_DOING condition, and also cluster_may_compress()
has checked CP_ERROR_FLAG condition, so remove redundant check condition
in __cluster_may_compress() for cleanup.

Signed-off-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 2e22d48d

fs/f2fs/compress.c

+1 −7
Original line number Diff line number Diff line
@@ -890,7 +890,6 @@ bool f2fs_cluster_can_merge_page(struct compress_ctx *cc, pgoff_t index) 


static bool __cluster_may_compress(struct compress_ctx *cc)

{

	struct f2fs_sb_info *sbi = F2FS_I_SB(cc->inode);

	loff_t i_size = i_size_read(cc->inode);

	unsigned nr_pages = DIV_ROUND_UP(i_size, PAGE_SIZE);

	int i;
@@ -898,12 +897,7 @@ static bool __cluster_may_compress(struct compress_ctx *cc) 
	for (i = 0; i < cc->cluster_size; i++) {

		struct page *page = cc->rpages[i];



		f2fs_bug_on(sbi, !page);



		if (unlikely(f2fs_cp_error(sbi)))

			return false;

		if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))

			return false;

		f2fs_bug_on(F2FS_I_SB(cc->inode), !page);



		/* beyond EOF */

		if (page->index >= nr_pages)