Commit 8af016aa authored by Stefan Potyra's avatar Stefan Potyra Committed by Greg Kroah-Hartman
Browse files

serial: 8250_dw: Disable clock on error 



If there is no clock rate for uartclk defined, disable the previously
enabled clock again.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 23f5b3fd serial: 8250_dw: only get the clock rate in one place
Signed-off-by: default avatarStefan Potyra <Stefan.Potyra@elektrobit.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0858fe3c

drivers/tty/serial/8250/8250_dw.c

+2 −1
Original line number Diff line number Diff line
@@ -515,7 +515,8 @@ static int dw8250_probe(struct platform_device *pdev) 
	/* If no clock rate is defined, fail. */

	if (!p->uartclk) {

		dev_err(dev, "clock rate not defined\n");

		return -EINVAL;

		err = -EINVAL;

		goto err_clk;

	}



	data->pclk = devm_clk_get(dev, "apb_pclk");