Commit 8ae3cebc authored by Ben Widawsky's avatar Ben Widawsky Committed by Dan Williams
Browse files

cxl/core: Use is_endpoint_decoder 



Save some characters and directly check decoder type rather than port
type. There's no need to check if the port is an endpoint port since, by
this point, cxl_endpoint_decoder_alloc() has a specified type.

Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
Signed-off-by: default avatarBen Widawsky <ben.widawsky@intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent db9a3a35

drivers/cxl/core/hdm.c

+1 −1
Original line number Diff line number Diff line
@@ -197,7 +197,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld, 
	else

		cxld->target_type = CXL_DECODER_ACCELERATOR;



	if (is_cxl_endpoint(to_cxl_port(cxld->dev.parent)))

	if (is_endpoint_decoder(&cxld->dev))

		return 0;



	target_list.value =

drivers/cxl/core/port.c

+1 −1
Original line number Diff line number Diff line
@@ -272,7 +272,7 @@ static const struct device_type cxl_decoder_root_type = { 
	.groups = cxl_decoder_root_attribute_groups,

};



static bool is_endpoint_decoder(struct device *dev)

bool is_endpoint_decoder(struct device *dev)

{

	return dev->type == &cxl_decoder_endpoint_type;

}

drivers/cxl/cxl.h

+1 −0
Original line number Diff line number Diff line
@@ -340,6 +340,7 @@ struct cxl_dport *cxl_find_dport_by_dev(struct cxl_port *port, 


struct cxl_decoder *to_cxl_decoder(struct device *dev);

bool is_root_decoder(struct device *dev);

bool is_endpoint_decoder(struct device *dev);

bool is_cxl_decoder(struct device *dev);

struct cxl_decoder *cxl_root_decoder_alloc(struct cxl_port *port,

					   unsigned int nr_targets);