Commit 8a48ac33 authored by Jani Nikula's avatar Jani Nikula
Browse files

video: constify fb ops across all drivers 



Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.

This does not cover all drivers; some actually modify the fbops struct,
for example to adjust for different configurations, and others do more
involved things that I'd rather not touch in practically obsolete
drivers. Mostly this is the low hanging fruit where we can add "const"
and be done with it.

v3:
- un-constify atyfb, mb862xx, nvidia and uvesabf (0day)

v2:
- fix typo (Christophe de Dinechin)
- use "static const" instead of "const static" in mx3fb.c
- also constify smscufx.c

Cc: linux-fbdev@vger.kernel.org
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/ce67f14435f3af498f2e8bf35ce4be11f7504132.1575390740.git.jani.nikula@intel.com
parent 28318ac1

drivers/video/fbdev/68328fb.c

+1 −1
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ static int mc68x328fb_pan_display(struct fb_var_screeninfo *var, 
			   struct fb_info *info);

static int mc68x328fb_mmap(struct fb_info *info, struct vm_area_struct *vma);



static struct fb_ops mc68x328fb_ops = {

static const struct fb_ops mc68x328fb_ops = {

	.fb_check_var	= mc68x328fb_check_var,

	.fb_set_par	= mc68x328fb_set_par,

	.fb_setcolreg	= mc68x328fb_setcolreg,

drivers/video/fbdev/acornfb.c

+1 −1
Original line number Diff line number Diff line
@@ -604,7 +604,7 @@ acornfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info) 
	return 0;

}



static struct fb_ops acornfb_ops = {

static const struct fb_ops acornfb_ops = {

	.owner		= THIS_MODULE,

	.fb_check_var	= acornfb_check_var,

	.fb_set_par	= acornfb_set_par,

drivers/video/fbdev/amba-clcd.c

+1 −1
Original line number Diff line number Diff line
@@ -423,7 +423,7 @@ static int clcdfb_mmap(struct fb_info *info, 
	return ret;

}



static struct fb_ops clcdfb_ops = {

static const struct fb_ops clcdfb_ops = {

	.owner		= THIS_MODULE,

	.fb_check_var	= clcdfb_check_var,

	.fb_set_par	= clcdfb_set_par,

drivers/video/fbdev/amifb.c

+1 −1
Original line number Diff line number Diff line
@@ -3493,7 +3493,7 @@ static irqreturn_t amifb_interrupt(int irq, void *dev_id) 
}





static struct fb_ops amifb_ops = {

static const struct fb_ops amifb_ops = {

	.owner		= THIS_MODULE,

	.fb_check_var	= amifb_check_var,

	.fb_set_par	= amifb_set_par,

drivers/video/fbdev/arcfb.c

+1 −1
Original line number Diff line number Diff line
@@ -491,7 +491,7 @@ static ssize_t arcfb_write(struct fb_info *info, const char __user *buf, 
	return err;

}



static struct fb_ops arcfb_ops = {

static const struct fb_ops arcfb_ops = {

	.owner		= THIS_MODULE,

	.fb_open	= arcfb_open,

	.fb_read        = fb_sys_read,