Commit 89fbdbae authored by Saeed Mahameed's avatar Saeed Mahameed
Browse files

net/mlx5e: TC: Remove unused parameter from mlx5_tc_ct_add_no_trk_match() 



priv is never used in this function

Fixes: 7e36feeb ("net/mlx5e: CT: Don't offload tuple rewrites for established tuples")
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 1edae233

drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c

+1 −3
Original line number Diff line number Diff line
@@ -1026,9 +1026,7 @@ mlx5_tc_ct_skb_to_tuple(struct sk_buff *skb, struct mlx5_ct_tuple *tuple, 
	return false;

}



int

mlx5_tc_ct_add_no_trk_match(struct mlx5e_priv *priv,

			    struct mlx5_flow_spec *spec)

int mlx5_tc_ct_add_no_trk_match(struct mlx5_flow_spec *spec)

{

	u32 ctstate = 0, ctstate_mask = 0;

drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.h

+2 −5
Original line number Diff line number Diff line
@@ -108,9 +108,7 @@ mlx5_tc_ct_match_add(struct mlx5_tc_ct_priv *priv, 
		     struct flow_cls_offload *f,

		     struct mlx5_ct_attr *ct_attr,

		     struct netlink_ext_ack *extack);

int

mlx5_tc_ct_add_no_trk_match(struct mlx5e_priv *priv,

			    struct mlx5_flow_spec *spec);

int mlx5_tc_ct_add_no_trk_match(struct mlx5_flow_spec *spec);

int

mlx5_tc_ct_parse_action(struct mlx5_tc_ct_priv *priv,

			struct mlx5_flow_attr *attr,
@@ -167,8 +165,7 @@ mlx5_tc_ct_match_add(struct mlx5_tc_ct_priv *priv, 
}



static inline int

mlx5_tc_ct_add_no_trk_match(struct mlx5e_priv *priv,

			    struct mlx5_flow_spec *spec)

mlx5_tc_ct_add_no_trk_match(struct mlx5_flow_spec *spec)

{

	return 0;

}

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+1 −1
Original line number Diff line number Diff line
@@ -3233,7 +3233,7 @@ static bool modify_header_match_supported(struct mlx5e_priv *priv, 
	 *  we can't restore ct state

	 */

	if (!ct_clear && modify_tuple &&

	    mlx5_tc_ct_add_no_trk_match(priv, spec)) {

	    mlx5_tc_ct_add_no_trk_match(spec)) {

		NL_SET_ERR_MSG_MOD(extack,

				   "can't offload tuple modify header with ct matches");

		netdev_info(priv->netdev,