Commit 89e4a00f authored by Íñigo Huguet's avatar Íñigo Huguet Committed by Kalle Valo
Browse files

rtw89: fix maybe uninitialized `qempty` variable 



Call to dle_dfi_qempty might fail, leaving qempty.qempty untouched, which
is latter used to control the for loop. If that happens, it's not
initialized anywhere.

Initialize it so the loop doesn't iterate unless it's modified by the
call to dle_dfi_qempty.

Signed-off-by: default avatarÍñigo Huguet <ihuguet@redhat.com>
Acked-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220113094253.73370-1-ihuguet@redhat.com
parent e0925375

drivers/net/wireless/realtek/rtw89/mac.c

+1 −0
Original line number Diff line number Diff line
@@ -172,6 +172,7 @@ static void rtw89_mac_dump_qta_lost(struct rtw89_dev *rtwdev) 


	qempty.dle_type = DLE_CTRL_TYPE_PLE;

	qempty.grpsel = 0;

	qempty.qempty = ~(u32)0;

	ret = dle_dfi_qempty(rtwdev, &qempty);

	if (ret)

		rtw89_warn(rtwdev, "%s: query DLE fail\n", __func__);