Commit 89d58aeb authored by Brian Silverman's avatar Brian Silverman Committed by Marc Kleine-Budde
Browse files

can: gs_usb: gs_can_start_xmit(): zero-initialize hf->{flags,reserved} 

No information is deliberately sent in hf->flags in host -> device
communications, but the open-source candleLight firmware echoes it
back, which can result in the GS_CAN_FLAG_OVERFLOW flag being set and
generating spurious ERRORFRAMEs.

While there also initialize the reserved member with 0.

Fixes: d08e973a ("can: gs_usb: Added support for the GS_USB CAN devices")
Link: https://lore.kernel.org/all/20220106002952.25883-1-brian.silverman@bluerivertech.com
Link: https://github.com/candle-usb/candleLight_fw/issues/87


Cc: stable@vger.kernel.org
Signed-off-by: default avatarBrian Silverman <brian.silverman@bluerivertech.com>
[mkl: initialize the reserved member, too]
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 72b1e360

drivers/net/can/usb/gs_usb.c

+2 −0
Original line number Diff line number Diff line
@@ -508,6 +508,8 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb, 


	hf->echo_id = idx;

	hf->channel = dev->channel;

	hf->flags = 0;

	hf->reserved = 0;



	cf = (struct can_frame *)skb->data;