Commit 89c83735 authored by Steven Rostedt's avatar Steven Rostedt Committed by Catalin Marinas
Browse files

kmemleak: No need for scanning specific module sections 



As kmemleak now scans all module sections that are allocated, writable
and non executable, there's no need to scan individual sections that
might reference data.

Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Acked-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 06c9494c

kernel/module.c

+0 −13
Original line number Diff line number Diff line
@@ -2769,24 +2769,11 @@ static void find_module_sections(struct module *mod, struct load_info *info) 
	mod->trace_events = section_objs(info, "_ftrace_events",

					 sizeof(*mod->trace_events),

					 &mod->num_trace_events);

	/*

	 * This section contains pointers to allocated objects in the trace

	 * code and not scanning it leads to false positives.

	 */

	kmemleak_scan_area(mod->trace_events, sizeof(*mod->trace_events) *

			   mod->num_trace_events, GFP_KERNEL);

#endif

#ifdef CONFIG_TRACING

	mod->trace_bprintk_fmt_start = section_objs(info, "__trace_printk_fmt",

					 sizeof(*mod->trace_bprintk_fmt_start),

					 &mod->num_trace_bprintk_fmt);

	/*

	 * This section contains pointers to allocated objects in the trace

	 * code and not scanning it leads to false positives.

	 */

	kmemleak_scan_area(mod->trace_bprintk_fmt_start,

			   sizeof(*mod->trace_bprintk_fmt_start) *

			   mod->num_trace_bprintk_fmt, GFP_KERNEL);

#endif

#ifdef CONFIG_FTRACE_MCOUNT_RECORD

	/* sechdrs[0].sh_size is always zero */