Commit 89a9dda1 authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Kalle Valo
Browse files

wifi: ath12k: relax list iteration in ath12k_mac_vif_unref() 



In ath12k_mac_vif_unref() dp->tx_desc_used_list[i]
is not altered so list_for_each_entry() should be safe.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230704173718.73462-1-dmantipov@yandex.ru
parent 07c01b86

drivers/net/wireless/ath/ath12k/mac.c

+3 −3
Original line number Diff line number Diff line
@@ -5542,7 +5542,7 @@ static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw, 


static void ath12k_mac_vif_unref(struct ath12k_dp *dp, struct ieee80211_vif *vif)

{

	struct ath12k_tx_desc_info *tx_desc_info, *tmp1;

	struct ath12k_tx_desc_info *tx_desc_info;

	struct ath12k_skb_cb *skb_cb;

	struct sk_buff *skb;

	int i;
@@ -5550,7 +5550,7 @@ static void ath12k_mac_vif_unref(struct ath12k_dp *dp, struct ieee80211_vif *vif 
	for (i = 0; i < ATH12K_HW_MAX_QUEUES; i++) {

		spin_lock_bh(&dp->tx_desc_lock[i]);



		list_for_each_entry_safe(tx_desc_info, tmp1, &dp->tx_desc_used_list[i],

		list_for_each_entry(tx_desc_info, &dp->tx_desc_used_list[i],

				    list) {

			skb = tx_desc_info->skb;

			if (!skb)