Unverified Commit 899a9a7f authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: amd: acp: Fix signedness bug in renoir_audio_probe() 



The "adata->i2s_irq" is unsigned so this error handling will not
work.

Fixes: 3304a242 ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220304131449.GC28739@kili


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8f2b025a

sound/soc/amd/acp/acp-renoir.c

+4 −3
Original line number Diff line number Diff line
@@ -282,9 +282,10 @@ static int renoir_audio_probe(struct platform_device *pdev) 
	if (!adata->acp_base)

		return -ENOMEM;



	adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");

	if (adata->i2s_irq < 0)

		return -ENODEV;

	ret = platform_get_irq_byname(pdev, "acp_dai_irq");

	if (ret < 0)

		return ret;

	adata->i2s_irq = ret;



	adata->dev = dev;

	adata->dai_driver = acp_renoir_dai;