Commit 896dcabd authored Jul 08, 2022 by Dan Carpenter Committed by Rodrigo Vivi Jul 12, 2022

drm/i915/selftests: fix a couple IS_ERR() vs NULL tests



The shmem_pin_map() function doesn't return error pointers, it returns
NULL.

Fixes: be1cb55a ("drm/i915/gt: Keep a no-frills swappable copy of the default context state")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220708094104.GL2316@kadam


(cherry picked from commit d50f5a10)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

parent f9954629

drivers/gpu/drm/i915/gt/selftest_lrc.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -176,8 +176,8 @@ static int live_lrc_layout(void *arg)
		continue;

		hw = shmem_pin_map(engine->default_state);
		if (IS_ERR(hw)) {
		err = PTR_ERR(hw);
		if (!hw) {
		err = -ENOMEM;
		break;
		}
		hw += LRC_STATE_OFFSET / sizeof(*hw);
		@@ -365,8 +365,8 @@ static int live_lrc_fixed(void *arg)
		continue;

		hw = shmem_pin_map(engine->default_state);
		if (IS_ERR(hw)) {
		err = PTR_ERR(hw);
		if (!hw) {
		err = -ENOMEM;
		break;
		}
		hw += LRC_STATE_OFFSET / sizeof(*hw);