Commit 895fa596 authored Dec 06, 2022 by Li Qiong Committed by Pablo Neira Ayuso Dec 08, 2022

netfilter: flowtable: add a 'default' case to flowtable datapath



Add a 'default' case in case return a uninitialized value of ret, this
should not ever happen since the follow transmit path types:

- FLOW_OFFLOAD_XMIT_UNSPEC
- FLOW_OFFLOAD_XMIT_TC

are never observed from this path. Add this check for safety reasons.

Signed-off-by: Li Qiong <liqiong@nfschina.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 7d7cfb48

net/netfilter/nf_flow_table_ip.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -421,6 +421,10 @@ nf_flow_offload_ip_hook(void priv, struct sk_buff skb,
		if (ret == NF_DROP)
		flow_offload_teardown(flow);
		break;
		default:
		WARN_ON_ONCE(1);
		ret = NF_DROP;
		break;
		}

		return ret;
		@@ -682,6 +686,10 @@ nf_flow_offload_ipv6_hook(void priv, struct sk_buff skb,
		if (ret == NF_DROP)
		flow_offload_teardown(flow);
		break;
		default:
		WARN_ON_ONCE(1);
		ret = NF_DROP;
		break;
		}

		return ret;