Commit 8954c44f authored Feb 01, 2023 by Xu Panda Committed by Darrick J. Wong Feb 05, 2023

xfs: use strscpy() to instead of strncpy()



The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.

Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>

parent 6d796c50

fs/xfs/xfs_xattr.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -212,9 +212,7 @@ __xfs_xattr_put_listent(
		offset = context->buffer + context->count;
		memcpy(offset, prefix, prefix_len);
		offset += prefix_len;
		strncpy(offset, (char )name, namelen); / real name */
		offset += namelen;
		*offset = '\0';
		strscpy(offset, (char )name, namelen + 1); / real name */

		compute_size:
		context->count += prefix_len + namelen + 1;