Commit 893351be authored by Gioh Kim's avatar Gioh Kim Committed by Zheng Zengkai
Browse files

RDMA/rtrs: Define MIN_CHUNK_SIZE 

stable inclusion
from stable-v5.10.137
commit 2b3dcfbece1c2a7dcf69616db7bdab77d0132354
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I60PLB

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2b3dcfbece1c2a7dcf69616db7bdab77d0132354

--------------------------------

[ Upstream commit 3f3d0eab ]

Define MIN_CHUNK_SIZE to replace the hard-coding number.
We need 4k for metadata, so MIN_CHUNK_SIZE should be at least 8k.

Link: https://lore.kernel.org/r/20210528113018.52290-7-jinpu.wang@ionos.com


Signed-off-by: default avatarGioh Kim <gi-oh.kim@ionos.com>
Signed-off-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
Reviewed-by: default avatarWei Li <liwei391@huawei.com>
parent da13ea25

drivers/infiniband/ulp/rtrs/rtrs-pri.h

+1 −0
Original line number Diff line number Diff line
@@ -56,6 +56,7 @@ enum { 
	 * somewhere between 1 and 65536 and it depends on the system.

	 */

	MAX_SESS_QUEUE_DEPTH = 65536,

	MIN_CHUNK_SIZE = 8192,



	RTRS_HB_INTERVAL_MS = 5000,

	RTRS_HB_MISSED_MAX = 5,

drivers/infiniband/ulp/rtrs/rtrs-srv.c

+2 −2
Original line number Diff line number Diff line
@@ -2193,9 +2193,9 @@ static int check_module_params(void) 
		       sess_queue_depth, 1, MAX_SESS_QUEUE_DEPTH);

		return -EINVAL;

	}

	if (max_chunk_size < 4096 || !is_power_of_2(max_chunk_size)) {

	if (max_chunk_size < MIN_CHUNK_SIZE || !is_power_of_2(max_chunk_size)) {

		pr_err("Invalid max_chunk_size value %d, has to be >= %d and should be power of two.\n",

		       max_chunk_size, 4096);

		       max_chunk_size, MIN_CHUNK_SIZE);

		return -EINVAL;

	}