Commit 89317d42 authored by Guilherme G. Piccoli's avatar Guilherme G. Piccoli Committed by Alex Deucher
Browse files

drm/amd/pm: Fix incorrect comment about Vangogh power cap support 



The comment mentions that power1 cap attributes are not supported on
Vangogh, but the opposite is indeed valid: for APUs, only Vangogh is
supported. While at it, also fixed the Renoir comment below (thanks
Melissa for noticing that!).

Cc: Lijo Lazar <lijo.lazar@amd.com>
Cc: Melissa Wen <mwen@igalia.com>
Signed-off-by: default avatarGuilherme G. Piccoli <gpiccoli@igalia.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 207bbfb6

drivers/gpu/drm/amd/pm/amdgpu_pm.c

+2 −2
Original line number Diff line number Diff line
@@ -3395,7 +3395,7 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj, 
	      attr == &sensor_dev_attr_pwm1_enable.dev_attr.attr)) /* can't manage state */

		effective_mode &= ~S_IWUSR;



	/* not implemented yet for GC 10.3.1 APUs */

	/* In the case of APUs, this is only implemented on Vangogh */

	if (((adev->family == AMDGPU_FAMILY_SI) ||

	     ((adev->flags & AMD_IS_APU) && (gc_ver != IP_VERSION(10, 3, 1)))) &&

	    (attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr ||
@@ -3404,7 +3404,7 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj, 
	     attr == &sensor_dev_attr_power1_cap_default.dev_attr.attr))

		return 0;



	/* not implemented yet for APUs having <= GC 9.3.0 */

	/* not implemented yet for APUs having < GC 9.3.0 (Renoir) */

	if (((adev->family == AMDGPU_FAMILY_SI) ||

	     ((adev->flags & AMD_IS_APU) && (gc_ver < IP_VERSION(9, 3, 0)))) &&

	    (attr == &sensor_dev_attr_power1_average.dev_attr.attr))