Commit 8923137d authored Jul 19, 2023 by Alex Sierra Committed by Alex Deucher Jul 25, 2023

drm/amdkfd: avoid svm dump when dynamic debug disabled



Set dynamic_svm_range_dump macro to avoid iterating over SVM lists
from svm_range_debug_dump when dynamic debug is disabled. Otherwise,
it could drop performance, specially with big number of SVM ranges.
Make sure both svm_range_set_attr and svm_range_debug_dump functions
are dynamically enabled to print svm_range_debug_dump debug traces.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Tested-by: Alex Sierra <alex.sierra@amd.com>
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent abbd6cfb

drivers/gpu/drm/amd/amdkfd/kfd_svm.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -46,6 +46,8 @@
		* page table is updated.
		*/
		#define AMDGPU_SVM_RANGE_RETRY_FAULT_PENDING (2UL * NSEC_PER_MSEC)
		#define dynamic_svm_range_dump(svms) \
		_dynamic_func_call_no_desc("svm_range_dump", svm_range_debug_dump, svms)

		/* Giant svm range split into smaller ranges based on this, it is decided using
		* minimum of all dGPU/APU 1/32 VRAM size, between 2MB to 1GB and alignment to
		@@ -3563,7 +3565,7 @@ svm_range_set_attr(struct kfd_process p, struct mm_struct mm,
		break;
		}

		svm_range_debug_dump(svms);
		dynamic_svm_range_dump(svms);

		mutex_unlock(&svms->lock);
		mmap_read_unlock(mm);