Commit 890d3356 authored by Vincent Whitchurch's avatar Vincent Whitchurch Committed by Michael S. Tsirkin
Browse files

virtio-ring: fix DMA metadata flags 



The flags are currently overwritten, leading to the wrong direction
being passed to the DMA unmap functions.

Fixes: 72b5e895 ("virtio-ring: store DMA metadata in desc_extra for split virtqueue")
Signed-off-by: default avatarVincent Whitchurch <vincent.whitchurch@axis.com>
Link: https://lore.kernel.org/r/20211026133100.17541-1-vincent.whitchurch@axis.com


Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
parent 0943aacf

drivers/virtio/virtio_ring.c

+1 −1
Original line number Diff line number Diff line
@@ -576,7 +576,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq, 
	/* Last one doesn't continue. */

	desc[prev].flags &= cpu_to_virtio16(_vq->vdev, ~VRING_DESC_F_NEXT);

	if (!indirect && vq->use_dma_api)

		vq->split.desc_extra[prev & (vq->split.vring.num - 1)].flags =

		vq->split.desc_extra[prev & (vq->split.vring.num - 1)].flags &=

			~VRING_DESC_F_NEXT;



	if (indirect) {