Commit 88fee1c9 authored by Bhawanpreet Lakha's avatar Bhawanpreet Lakha Committed by Lyude Paul
Browse files

drm/dp_mst: Don't return error code when crtc is null 



[Why]
In certain cases the crtc can be NULL and returning -EINVAL causes
atomic check to fail when it shouln't. This leads to valid
configurations failing because atomic check fails.

[How]
Don't early return if crtc is null

Signed-off-by: default avatarBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
[added stable cc]
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Fixes: 8ec04671 ("drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs")
Cc: <stable@vger.kernel.org> # v5.6+
Link: https://patchwork.freedesktop.org/patch/msgid/20200814170140.24917-1-Bhawanpreet.Lakha@amd.com
parent 836b194d

drivers/gpu/drm/drm_dp_mst_topology.c

+2 −2
Original line number Diff line number Diff line
@@ -4990,8 +4990,8 @@ int drm_dp_mst_add_affected_dsc_crtcs(struct drm_atomic_state *state, struct drm 


		crtc = conn_state->crtc;



		if (WARN_ON(!crtc))

			return -EINVAL;

		if (!crtc)

			continue;



		if (!drm_dp_mst_dsc_aux_for_port(pos->port))

			continue;