Commit 88885f66 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: improve sqo stop 



Set IO_SQ_THREAD_SHOULD_STOP before taking sqd lock, so the sqpoll task
sees earlier. Not a problem, it will stop eventually. Also check
invariant that it's stopped only once.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/653b24ee93843a50ff65a45847d9138f5adb76d7.1618101759.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent aeca241b

fs/io_uring.c

+2 −1
Original line number Diff line number Diff line
@@ -7229,9 +7229,10 @@ static void io_sq_thread_park(struct io_sq_data *sqd) 
static void io_sq_thread_stop(struct io_sq_data *sqd)

{

	WARN_ON_ONCE(sqd->thread == current);

	WARN_ON_ONCE(test_bit(IO_SQ_THREAD_SHOULD_STOP, &sqd->state));



	mutex_lock(&sqd->lock);

	set_bit(IO_SQ_THREAD_SHOULD_STOP, &sqd->state);

	mutex_lock(&sqd->lock);

	if (sqd->thread)

		wake_up_process(sqd->thread);

	mutex_unlock(&sqd->lock);