Commit 8877ecb0 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Guenter Roeck
Browse files

hwmon: (aquacomputer_d5next) Fix an error handling path in aqc_probe() 



If no memory can be allocated, some resources still need to be released as
already done in the other error handling paths.

Fixes: 752b9279 ("hwmon: (aquacomputer_d5next) Add support for Aquacomputer Octo")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/be6b955d50de140fcc96bd116150b435021bf567.1653225250.git.christophe.jaillet@wanadoo.fr


Reviewed-by: default avatarAleksa Savic <savicaleksa83@gmail.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 5ab312b3

drivers/hwmon/aquacomputer_d5next.c

+4 −2
Original line number Diff line number Diff line
@@ -783,8 +783,10 @@ static int aqc_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	priv->name = aqc_device_names[priv->kind];



	priv->buffer = devm_kzalloc(&hdev->dev, priv->buffer_size, GFP_KERNEL);

	if (!priv->buffer)

		return -ENOMEM;

	if (!priv->buffer) {

		ret = -ENOMEM;

		goto fail_and_close;

	}



	mutex_init(&priv->mutex);