Commit 88765294 authored by Muhammad Husaini Zulkifli's avatar Muhammad Husaini Zulkifli Committed by Tony Nguyen
Browse files

igc: Fix Pause Frame Advertising 



Fix Pause Frame Advertising when getting the advertisement via ethtool.
Remove setting the "advertising" bit in link_ksettings during default
case when Tx and Rx are in off state with Auto Negotiate off.

Below is the original output of advertisement link during Tx and Rx off:
Advertised pause frame use: Symmetric Receive-only

Expected output:
Advertised pause frame use: No

Fixes: 8c5ad0da ("igc: Add ethtool support")
Signed-off-by: default avatarMuhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Reviewed-by: default avatarMalli C <mallikarjuna.chilakala@intel.com>
Acked-by: default avatarSasha Neftin <sasha.neftin@intel.com>
Tested-by: default avatarDvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 6da26237

drivers/net/ethernet/intel/igc/igc_ethtool.c

+1 −3
Original line number Diff line number Diff line
@@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev, 
						     Asym_Pause);

		break;

	default:

		ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);

		ethtool_link_ksettings_add_link_mode(cmd, advertising,

						     Asym_Pause);

		break;

	}



	status = pm_runtime_suspended(&adapter->pdev->dev) ?