Unverified Commit 88541443 authored by Deepak R Varma's avatar Deepak R Varma Committed by Mark Brown
Browse files

ASoC: imx-pcm-rpmsg: Remove unused variable 



Variable ret is initialed but is never modified or used except for
returning the initial value 0. The value can be directly returned
instead and the variable definition can be dropped.
Issue identified using returnvar.cocci Coccinelle semantic patch.

Signed-off-by: default avatarDeepak R Varma <drv@mailo.com>
Link: https://lore.kernel.org/r/Y+p9r5y9DPSJkPVf@ubun2204.myguest.virtualbox.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f7d00a9b

sound/soc/fsl/imx-pcm-rpmsg.c

+2 −4
Original line number Diff line number Diff line
@@ -140,7 +140,6 @@ static int imx_rpmsg_pcm_hw_params(struct snd_soc_component *component, 
{

	struct rpmsg_info *info = dev_get_drvdata(component->dev);

	struct rpmsg_msg *msg;

	int ret = 0;



	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {

		msg = &info->msg[TX_HW_PARAM];
@@ -184,7 +183,7 @@ static int imx_rpmsg_pcm_hw_params(struct snd_soc_component *component, 


	info->send_message(msg, info);



	return ret;

	return 0;

}



static snd_pcm_uframes_t imx_rpmsg_pcm_pointer(struct snd_soc_component *component,
@@ -282,7 +281,6 @@ static int imx_rpmsg_pcm_close(struct snd_soc_component *component, 
	struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);

	struct rpmsg_info *info = dev_get_drvdata(component->dev);

	struct rpmsg_msg *msg;

	int ret = 0;



	/* Flush work in workqueue to make TX_CLOSE is the last message */

	flush_workqueue(info->rpmsg_wq);
@@ -305,7 +303,7 @@ static int imx_rpmsg_pcm_close(struct snd_soc_component *component, 
		dev_warn(rtd->dev, "Msg is dropped!, number is %d\n",

			 info->msg_drop_count[substream->stream]);



	return ret;

	return 0;

}



static int imx_rpmsg_pcm_prepare(struct snd_soc_component *component,