Commit 88328555 authored by Eugen Hristev's avatar Eugen Hristev Committed by Mauro Carvalho Chehab
Browse files

media: atmel: atmel-isc: create callback for DPC submodule product specific 



The DPC submodule is a part of the atmel-isc pipeline, and stands for
Defective Pixel Correction. Its purpose is to detect defective pixels and
correct them if possible with the help of adjacent pixels.
Create a product specific callback for initializing the DPC submodule
of the pipeline.
For sama5d2 product, this module does not exist, thus this function is a noop.

[hverkuil: made isc_sama5d2_config_dpc static]

Signed-off-by: default avatarEugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 8f1b451c

drivers/media/platform/atmel/atmel-isc-base.c

+1 −0
Original line number Diff line number Diff line
@@ -659,6 +659,7 @@ static void isc_set_pipeline(struct isc_device *isc, u32 pipeline) 
	regmap_bulk_write(regmap, ISC_GAM_GENTRY, gamma, GAMMA_ENTRIES);

	regmap_bulk_write(regmap, ISC_GAM_RENTRY, gamma, GAMMA_ENTRIES);



	isc->config_dpc(isc);

	isc->config_csc(isc);

	isc->config_cbc(isc);

	isc->config_cc(isc);

drivers/media/platform/atmel/atmel-isc.h

+3 −0
Original line number Diff line number Diff line
@@ -221,6 +221,8 @@ struct isc_reg_offsets { 
 * @max_width:		maximum frame width, dependent on the internal RAM

 * @max_height:		maximum frame height, dependent on the internal RAM

 *

 * @config_dpc:		pointer to a function that initializes product

 *			specific DPC module

 * @config_csc:		pointer to a function that initializes product

 *			specific CSC module

 * @config_cbc:		pointer to a function that initializes product
@@ -300,6 +302,7 @@ struct isc_device { 
	u32		max_height;



	struct {

		void (*config_dpc)(struct isc_device *isc);

		void (*config_csc)(struct isc_device *isc);

		void (*config_cbc)(struct isc_device *isc);

		void (*config_cc)(struct isc_device *isc);

drivers/media/platform/atmel/atmel-sama5d2-isc.c

+6 −0
Original line number Diff line number Diff line
@@ -107,6 +107,11 @@ static void isc_sama5d2_config_ctrls(struct isc_device *isc, 
	v4l2_ctrl_new_std(hdl, ops, V4L2_CID_CONTRAST, -2048, 2047, 1, 256);

}



static void isc_sama5d2_config_dpc(struct isc_device *isc)

{

	/* This module is not present on sama5d2 pipeline */

}



/* Gamma table with gamma 1/2.2 */

static const u32 isc_sama5d2_gamma_table[][GAMMA_ENTRIES] = {

	/* 0 --> gamma 1/1.8 */
@@ -252,6 +257,7 @@ static int atmel_isc_probe(struct platform_device *pdev) 
	isc->max_width = ISC_SAMA5D2_MAX_SUPPORT_WIDTH;

	isc->max_height = ISC_SAMA5D2_MAX_SUPPORT_HEIGHT;



	isc->config_dpc = isc_sama5d2_config_dpc;

	isc->config_csc = isc_sama5d2_config_csc;

	isc->config_cbc = isc_sama5d2_config_cbc;

	isc->config_cc = isc_sama5d2_config_cc;