Commit 882e013a authored by Geraldo Nascimento's avatar Geraldo Nascimento Committed by Takashi Iwai
Browse files

ALSA: usb-audio: fix comment reference in __uac_clock_find_source 



snd_usb_find_clock_source and snd_usb_find_clock_selector are helper
macros that look at an entity id and validate that this entity id is
in fact a clock source or a clock selector. The present comments
inside __uac_clock_find_source give the reader the impression we're
looking for an entity id.

We're looking for an entity id indeed, the clock source, but since
__uac_clock_find_source is recursive, we're also looking *at* the
entity ids, in the search for the one clock source.

Fix the comment so we don't give readers a wrong idea.

Signed-off-by: default avatarGeraldo Nascimento <geraldogabriel@gmail.com>
Link: https://lore.kernel.org/r/YU6Kj05oOqRmhJDf@geday


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f02f2f1b

sound/usb/clock.c

+2 −2
Original line number Diff line number Diff line
@@ -271,7 +271,7 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip, 
		return -EINVAL;

	}



	/* first, see if the ID we're looking for is a clock source already */

	/* first, see if the ID we're looking at is a clock source already */

	source = snd_usb_find_clock_source(chip, entity_id, proto);

	if (source) {

		entity_id = GET_VAL(source, proto, bClockID);
@@ -297,7 +297,7 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip, 
			goto find_source;

		}



		/* the entity ID we are looking for is a selector.

		/* the entity ID we are looking at is a selector.

		 * find out what it currently selects */

		ret = uac_clock_selector_get_val(chip, clock_id);

		if (ret < 0) {