Commit 87e0eacb authored by Dan Carpenter's avatar Dan Carpenter Committed by Jason Gunthorpe
Browse files

RDMA/nldev: Prevent underflow in nldev_stat_set_counter_dynamic_doit() 

This code checks "index" for an upper bound but it does not check for
negatives.  Change the type to unsigned to prevent underflows.

Fixes: 3c3c1f14 ("RDMA/nldev: Allow optional-counter status configuration through RDMA netlink")
Link: https://lore.kernel.org/r/20220316083948.GC30941@kili


Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 2e11a5e4

drivers/infiniband/core/nldev.c

+2 −1
Original line number Diff line number Diff line
@@ -1951,9 +1951,10 @@ static int nldev_stat_set_counter_dynamic_doit(struct nlattr *tb[], 
					       u32 port)

{

	struct rdma_hw_stats *stats;

	int rem, i, index, ret = 0;

	struct nlattr *entry_attr;

	unsigned long *target;

	int rem, i, ret = 0;

	u32 index;



	stats = ib_get_hw_stats_port(device, port);

	if (!stats)