Commit 87c97812 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jakub Kicinski
Browse files

octeontx2-af: cn10k: mcs: Fix a resource leak in the probe and remove functions 



In mcs_register_interrupts(), a call to request_irq() is not balanced by a
corresponding free_irq(), neither in the error handling path, nor in the
remove function.

Add the missing calls.

Fixes: 6c635f78 ("octeontx2-af: cn10k: mcs: Handle MCS block interrupts")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/69f153db5152a141069f990206e7389f961d41ec.1670693669.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a38a211e

drivers/net/ethernet/marvell/octeontx2/af/mcs.c

+5 −1
Original line number Diff line number Diff line
@@ -1184,10 +1184,13 @@ static int mcs_register_interrupts(struct mcs *mcs) 
	mcs->tx_sa_active = alloc_mem(mcs, mcs->hw->sc_entries);

	if (!mcs->tx_sa_active) {

		ret = -ENOMEM;

		goto exit;

		goto free_irq;

	}



	return ret;



free_irq:

	free_irq(pci_irq_vector(mcs->pdev, MCS_INT_VEC_IP), mcs);

exit:

	pci_free_irq_vectors(mcs->pdev);

	mcs->num_vec = 0;
@@ -1589,6 +1592,7 @@ static void mcs_remove(struct pci_dev *pdev) 


	/* Set MCS to external bypass */

	mcs_set_external_bypass(mcs, true);

	free_irq(pci_irq_vector(pdev, MCS_INT_VEC_IP), mcs);

	pci_free_irq_vectors(pdev);

	pci_release_regions(pdev);

	pci_disable_device(pdev);