Commit 87c272c6 authored by Julian Wiedmann's avatar Julian Wiedmann Committed by David S. Miller
Browse files

net/af_iucv: clean up some forward declarations 



The forward declarations for the iucv_handler callbacks are causing
various compile warnings with gcc-11. Reshuffle the code to get rid
of these prototypes.

Reported-by: default avatarSven Schnelle <svens@linux.ibm.com>
Signed-off-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1f1aa3fe

net/iucv/af_iucv.c

+10 −17
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ static struct proto iucv_proto = { 
};



static struct iucv_interface *pr_iucv;

static struct iucv_handler af_iucv_handler;



/* special AF_IUCV IPRM messages */

static const u8 iprm_shutdown[8] =
@@ -91,28 +92,11 @@ static void iucv_sock_close(struct sock *sk); 


static void afiucv_hs_callback_txnotify(struct sock *sk, enum iucv_tx_notify);



/* Call Back functions */

static void iucv_callback_rx(struct iucv_path *, struct iucv_message *);

static void iucv_callback_txdone(struct iucv_path *, struct iucv_message *);

static void iucv_callback_connack(struct iucv_path *, u8 *);

static int iucv_callback_connreq(struct iucv_path *, u8 *, u8 *);

static void iucv_callback_connrej(struct iucv_path *, u8 *);

static void iucv_callback_shutdown(struct iucv_path *, u8 *);



static struct iucv_sock_list iucv_sk_list = {

	.lock = __RW_LOCK_UNLOCKED(iucv_sk_list.lock),

	.autobind_name = ATOMIC_INIT(0)

};



static struct iucv_handler af_iucv_handler = {

	.path_pending	  = iucv_callback_connreq,

	.path_complete	  = iucv_callback_connack,

	.path_severed	  = iucv_callback_connrej,

	.message_pending  = iucv_callback_rx,

	.message_complete = iucv_callback_txdone,

	.path_quiesced	  = iucv_callback_shutdown,

};



static inline void high_nmcpy(unsigned char *dst, char *src)

{

       memcpy(dst, src, 8);
@@ -1817,6 +1801,15 @@ static void iucv_callback_shutdown(struct iucv_path *path, u8 ipuser[16]) 
	bh_unlock_sock(sk);

}



static struct iucv_handler af_iucv_handler = {

	.path_pending		= iucv_callback_connreq,

	.path_complete		= iucv_callback_connack,

	.path_severed		= iucv_callback_connrej,

	.message_pending	= iucv_callback_rx,

	.message_complete	= iucv_callback_txdone,

	.path_quiesced		= iucv_callback_shutdown,

};



/***************** HiperSockets transport callbacks ********************/

static void afiucv_swap_src_dest(struct sk_buff *skb)

{