Commit 87c16966 authored by Jens Axboe's avatar Jens Axboe
Browse files

io-wq: ensure we exit if thread group is exiting 



Dave reports that a coredumping workload gets stuck in 5.15-rc2, and
identified the culprit in the Fixes line below. The problem is that
relying solely on fatal_signal_pending() to gate whether to exit or not
fails miserably if a process gets eg SIGILL sent. Don't exclusively
rely on fatal signals, also check if the thread group is exiting.

Fixes: 15e20db2 ("io-wq: only exit on fatal signals")
Reported-by: default avatarDave Chinner <david@fromorbit.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e4e737bb

fs/io-wq.c

+2 −1
Original line number Diff line number Diff line
@@ -584,7 +584,8 @@ static int io_wqe_worker(void *data) 


			if (!get_signal(&ksig))

				continue;

			if (fatal_signal_pending(current))

			if (fatal_signal_pending(current) ||

			    signal_group_exit(current->signal))

				break;

			continue;

		}