Commit 87b1e9a5 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: via: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 4a5ef62c

drivers/video/fbdev/via/via-gpio.c

+2 −3
Original line number Diff line number Diff line
@@ -262,7 +262,7 @@ static int viafb_gpio_probe(struct platform_device *platdev) 
}





static int viafb_gpio_remove(struct platform_device *platdev)

static void viafb_gpio_remove(struct platform_device *platdev)

{

	unsigned long flags;

	int i;
@@ -285,7 +285,6 @@ static int viafb_gpio_remove(struct platform_device *platdev) 
		viafb_gpio_disable(viafb_gpio_config.active_gpios[i]);

	viafb_gpio_config.gpio_chip.ngpio = 0;

	spin_unlock_irqrestore(&viafb_gpio_config.vdev->reg_lock, flags);

	return 0;

}



static struct platform_driver via_gpio_driver = {
@@ -293,7 +292,7 @@ static struct platform_driver via_gpio_driver = { 
		.name = "viafb-gpio",

	},

	.probe = viafb_gpio_probe,

	.remove = viafb_gpio_remove,

	.remove_new = viafb_gpio_remove,

};



int viafb_gpio_init(void)

drivers/video/fbdev/via/via_i2c.c

+2 −3
Original line number Diff line number Diff line
@@ -246,7 +246,7 @@ static int viafb_i2c_probe(struct platform_device *platdev) 
	return 0;

}



static int viafb_i2c_remove(struct platform_device *platdev)

static void viafb_i2c_remove(struct platform_device *platdev)

{

	int i;
@@ -259,7 +259,6 @@ static int viafb_i2c_remove(struct platform_device *platdev) 
		if (i2c_stuff->is_active)

			i2c_del_adapter(&i2c_stuff->adapter);

	}

	return 0;

}



static struct platform_driver via_i2c_driver = {
@@ -267,7 +266,7 @@ static struct platform_driver via_i2c_driver = { 
		.name = "viafb-i2c",

	},

	.probe = viafb_i2c_probe,

	.remove = viafb_i2c_remove,

	.remove_new = viafb_i2c_remove,

};



int viafb_i2c_init(void)