Commit 8796acbc authored by Yu Kuai's avatar Yu Kuai Committed by Jens Axboe
Browse files

blk-iocost: disable writeback throttling 



Commit b5dc5d4d ("block,bfq: Disable writeback throttling") disable
wbt for bfq, because different write-throttling heuristics should not
work together.

For the same reason, wbt and iocost should not work together as well,
unless admin really want to do that, dispite that performance is
affected.

Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20221012094035.390056-2-yukuai1@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 247f34f7

block/blk-iocost.c

+2 −0
Original line number Diff line number Diff line
@@ -3264,9 +3264,11 @@ static ssize_t ioc_qos_write(struct kernfs_open_file *of, char *input, 
		blk_stat_enable_accounting(disk->queue);

		blk_queue_flag_set(QUEUE_FLAG_RQ_ALLOC_TIME, disk->queue);

		ioc->enabled = true;

		wbt_disable_default(disk->queue);

	} else {

		blk_queue_flag_clear(QUEUE_FLAG_RQ_ALLOC_TIME, disk->queue);

		ioc->enabled = false;

		wbt_enable_default(disk->queue);

	}



	if (user) {