Commit 87889943 authored Dec 04, 2019 by Rikard Falkeborn Committed by Linus Torvalds Dec 04, 2019

linux/build_bug.h: change type to int

Having BUILD_BUG_ON_ZERO produce a value of type size_t leads to awkward
casts in cases where the result needs to be signed, or of smaller type
than size_t.  To avoid this, cast the value to int instead and rely on
implicit type conversions when a larger or unsigned type is needed.

Link: http://lkml.kernel.org/r/20190811184938.1796-3-rikard.falkeborn@gmail.com


Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Joe Perches <joe@perches.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a512ae54

include/linux/build_bug.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -9,11 +9,11 @@
		#else /* __CHECKER__ */
		/*
		* Force a compilation error if condition is true, but also produce a
		* result (of value 0 and type size_t), so the expression can be used
		* result (of value 0 and type int), so the expression can be used
		* e.g. in a structure initializer (or where-ever else comma expressions
		* aren't permitted).
		*/
		#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
		#define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); })))
		#endif /* __CHECKER__ */

		/* Force a compilation error if a constant expression is not a power of 2 */