Commit 8782007b authored by Luben Tuikov's avatar Luben Tuikov Committed by Alex Deucher
Browse files

drm/amdgpu: Return from switch early for EEPROM I2C address 



As soon as control->i2c_address is set, return; remove the "break;" from the
switch--it is unnecessary. This mimics what happens when for some cases in the
switch, we call helper functions with "return <helper function>".

Remove final function "return true;" to indicate that the switch is final and
terminal, and that there should be no code after the switch.

Cc: Candice Li <candice.li@amd.com>
Cc: Kent Russell <kent.russell@amd.com>
Cc: Alex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: default avatarLuben Tuikov <luben.tuikov@amd.com>
Reviewed-by: default avatarAlex Deucher <Alexander.Deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1bb745d7

drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c

+3 −5
Original line number Diff line number Diff line
@@ -181,14 +181,14 @@ static bool __get_eeprom_i2c_addr(struct amdgpu_device *adev, 
	switch (adev->asic_type) {

	case CHIP_VEGA20:

		control->i2c_address = EEPROM_I2C_MADDR_0;

		break;

		return true;



	case CHIP_ARCTURUS:

		return __get_eeprom_i2c_addr_arct(adev, control);



	case CHIP_SIENNA_CICHLID:

		control->i2c_address = EEPROM_I2C_MADDR_0;

		break;

		return true;



	case CHIP_ALDEBARAN:

		if (strnstr(atom_ctx->vbios_version, "D673",
@@ -196,7 +196,7 @@ static bool __get_eeprom_i2c_addr(struct amdgpu_device *adev, 
			control->i2c_address = EEPROM_I2C_MADDR_4;

		else

			control->i2c_address = EEPROM_I2C_MADDR_0;

		break;

		return true;



	case CHIP_IP_DISCOVERY:

		return __get_eeprom_i2c_addr_ip_discovery(adev, control);
@@ -204,8 +204,6 @@ static bool __get_eeprom_i2c_addr(struct amdgpu_device *adev, 
	default:

		return false;

	}



	return true;

}



static void