Unverified Commit 87447763 authored by Shuming Fan's avatar Shuming Fan Committed by Mark Brown
Browse files

ASoC: rt1316: fix key tone missing 



This patch adds a control that there are three options to control the digital volume output.
The user could select "immediately" to make volume updates immediately
and avoid key tone missing issues.
In default, the driver selects that the volume update when a zero-crossing with a soft ramp.

Signed-off-by: default avatarShuming Fan <shumingf@realtek.com>
Reported-by: default avatarVijendar Mukunda <Vijendar.Mukunda@amd.com>
Link: https://lore.kernel.org/r/20230726091051.658754-1-shumingf@realtek.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f6500ec1

sound/soc/codecs/rt1316-sdw.c

+12 −0
Original line number Diff line number Diff line
@@ -424,6 +424,15 @@ static SOC_ENUM_SINGLE_DECL(rt1316_rx_data_ch_enum, 
	SDW_SDCA_CTL(FUNC_NUM_SMART_AMP, RT1316_SDCA_ENT_UDMPU21, RT1316_SDCA_CTL_UDMPU_CLUSTER, 0), 0,

	rt1316_rx_data_ch_select);



static const char * const rt1316_dac_output_vol_select[] = {

	"immediately",

	"zero crossing",

	"zero crossing with soft ramp",

};



static SOC_ENUM_SINGLE_DECL(rt1316_dac_vol_ctl_enum,

	0xc010, 6, rt1316_dac_output_vol_select);



static const struct snd_kcontrol_new rt1316_snd_controls[] = {



	/* I2S Data Channel Selection */
@@ -442,6 +451,9 @@ static const struct snd_kcontrol_new rt1316_snd_controls[] = { 
	/* IV mixer Control */

	SOC_DOUBLE("Isense Mixer Switch", 0xc605, 2, 0, 1, 1),

	SOC_DOUBLE("Vsense Mixer Switch", 0xc605, 3, 1, 1, 1),



	/* DAC Output Volume Control */

	SOC_ENUM("DAC Output Vol Control", rt1316_dac_vol_ctl_enum),

};



static const struct snd_kcontrol_new rt1316_sto_dac =